Support map values in (when)#191
Merged
alexander-yevsyukov merged 10 commits intomasterfrom May 1, 2026
Merged
Conversation
alexander-yevsyukov
changed the title
(when)
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #191 +/- ##
============================================
- Coverage 84.27% 83.88% -0.39%
Complexity 304 304
============================================
Files 60 60
Lines 1081 1086 +5
Branches 45 46 +1
============================================
Hits 911 911
- Misses 160 165 +5
Partials 10 10 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
This PR extends the time (when) validation option to support map fields whose values are google.protobuf.Timestamp or Spine Temporal types, and reorganizes the test suite accordingly while bumping project/config versions.
Changes:
- Add
(when)codegen/support for map-valued fields in thevalidationmodule. - Add new proto fixtures and split tests by field “shape” (single/repeated/map) and by time type (Timestamp/Temporal), with shared time fixtures.
- Apply latest config updates and bump snapshot versions / dependency reports.
Reviewed changes
Copilot reviewed 32 out of 33 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| version.gradle.kts | Bumps versionToPublish to 2.0.0-SNAPSHOT.237. |
| validation/.../WhenOption.kt | Allows (when) to consider map field types during type classification. |
| validation/.../WhenGenerator.kt | Generates validation code that iterates over map values and validates each element. |
| tests/.../when_map.proto | Adds proto fixtures for (when) on map values (Timestamp + Temporal). |
| tests/.../TimestampWhenSpec.kt | New tests for single Timestamp fields with (when). |
| tests/.../TimestampWhenMapSpec.kt | New tests for map-of-Timestamp fields with (when). |
| tests/.../TimestampRepeatedWhenSpec.kt | Refactors repeated Timestamp tests to use shared fixtures and new suite naming. |
| tests/.../TemporalWhenSpec.kt | New tests for single Temporal fields with (when). |
| tests/.../TemporalWhenMapSpec.kt | New tests for map-of-Temporal fields with (when). |
| tests/.../TemporalRepeatedWhenSpec.kt | New tests for repeated Temporal fields with (when). |
| tests/.../SpineTemporalWhenSpec.kt | Removes old combined Temporal test suite (replaced by split specs). |
| tests/.../Fixtures.kt | Introduces shared TimestampFixtures / TemporalFixtures. |
| pom.xml | Regenerated POM content updated; introduces new dependencies/versions (see comments). |
| dependencies.md | Regenerated license/dependency report with new version headers/timestamps. |
| buildSrc/.../Validation.kt | Bumps Validation dependency version to 2.0.0-SNAPSHOT.414. |
| buildSrc/.../Time.kt | Bumps Time dependency version to 2.0.0-SNAPSHOT.236. |
| buildSrc/.../CoreJvmCompiler.kt | Bumps compiler dogfooding version to 2.0.0-SNAPSHOT.063. |
| buildSrc/.../Dokka.kt | Removes an unused import. |
| buildSrc/build.gradle.kts | Updates Shadow plugin version/comment block. |
| .junie/guidelines.md | Updates Junie guidelines wording. |
| .gitignore | Ignores .junie/memory/. |
| .github/workflows/*.yml(yaml) | Renames some workflow/job display names. |
| .agents/skills/java-to-kotlin/* | Adds “java-to-kotlin” skill metadata. |
| .agents/quick-reference-card.md | Removes a tools recommendation line. |
| .agents/_TOC.md | Points TOC entry to the new skill doc location. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
armiol
approved these changes
May 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR extends the
validationmodule with the support of map values constrained with the(when)option.Other notable changes
testwere split by types of the checked fields.configwas applied.